Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request
Date: 2017-06-22 08:31:34
Message-ID: CAKKotZRUr59OBuJ4GdWbSn1rW12ONm4BZCr0F4FW6_Lp0rC=YA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Khusboo,

Looks like given change have broken Backup, Restore, Import/Export &
Maintenance, even if I have binary path set it is throwing an error.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 21, 2017 at 9:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks, patch applied!
>
> On Wed, Jun 21, 2017 at 12:44 PM, Khushboo Vashi
> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > Please find attached patch to fix RM #2487: get_preference() uses a
> > synchronous AJAX request.
> >
> > Introduced the client side caching for preferences to get rid of
> synchronous
> > AJAX request.
> >
> >
> > Thanks,
> > Khushboo
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-06-22 08:48:05 Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request
Previous Message Dave Page 2017-06-22 08:03:14 Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4