Re: Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers
Date: 2016-06-24 11:24:30
Message-ID: CAKKotZRRWxz2WhJQGonTn4YkPBDS7GYLL3xWM1xfaNFvRGO_HA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

PFA patch to fix the issue RM#1292.

Earlier patch was not handling spaces properly.
e.g- If user creates any objects which has spaces in its name then it fails
to parse it next time user select it.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jun 20, 2016 at 8:34 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks, patch applied.
>
> On Mon, Jun 20, 2016 at 2:56 PM, Sanket Mehta
> <sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > PFA the revised patch to resolve this issue which consists the change in
> > control formatter.
> >
> >
> > Regards,
> > Sanket Mehta
> > Sr Software engineer
> > Enterprisedb
> >
> > On Mon, Jun 13, 2016 at 3:12 PM, <redmine(at)postgresql(dot)org> wrote:
> >>
> >> Issue #1292 has been updated by Dave Page.
> >>
> >> Target version deleted (1.0 Beta 1)
> >>
> >> ________________________________
> >>
> >> Bug #1292: ERROR: template database "!(at)#$%^&*()_+{}|:"<>?=-\\][';/.,"
> does
> >> not exist message throws if template database contain special charterers
> >>
> >> Author: Fahar Abbas
> >> Status: In Progress
> >> Priority: Normal
> >> Assignee: Sanket Mehta
> >> Category:
> >> Target version:
> >>
> >> Commit ID:
> >> -----------
> >> commit 954163b4957c1dce89c0632d009b845cbe90faf4
> >>
> >> Browser version:
> >> ----------------
> >> Firefox 45.0.2
> >>
> >> Python version:
> >> ----------------
> >> 3.5.1+
> >>
> >> Platforms:
> >> All
> >>
> >> ERROR: template database "!(at)#$%^&*()_+{}|:"<>?=-\\][';/.," does not
> exist
> >> message throws if user try to create database with template database
> that
> >> name contain special charterers.
> >>
> >> Please note that this issue is not reproducible in other template
> >> databases that name is simple one.
> >>
> >> Please note that this is not reproduce in pgAdmin3.
> >>
> >> Steps:
> >>
> >> 1. Install pgAdmin4 on Ubuntu 16.04
> >> 2. Install PG-9.6-beta 1 installer
> >> 3. Expand database node
> >> 4. give it's name !#$%^&*()_+{}|:"<>?=-\][';/.,
> >> 5. Database created successfully
> >> 6. Again create new database and give it's name abcd
> >> 7. Click on definition tab
> >> 8. select template database !#$%^&*()_+{}|:"<>?=-\][';/.,
> >> 9. Click on Save button
> >>
> >> Files Screen Shot 2016-06-02 at 10.25.34 am.png (1020 KB)
> >> Screen Shot 2016-06-02 at 10.26.01 am.png (1.03 MB)
> >> ________________________________
> >>
> >> You have received this notification because you have either subscribed
> to
> >> it, or are involved in it.
> >> To change your notification preferences, please click here:
> >> https://redmine.postgresql.org/my/account
> >
> >
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

Attachment Content-Type Size
RM_1292.patch application/octet-stream 624 bytes

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-06-24 11:50:56 pgAdmin 4 commit: Move the config database schema version out of the co
Previous Message Dave Page 2016-06-24 10:47:21 Re: pgAdmin IV API test cases patch