Re: pgAdmin 4 commit: Ensure that the original file format should be retain

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, Yogesh Jain <yogesh(dot)jain(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgAdmin 4 commit: Ensure that the original file format should be retain
Date: 2020-08-05 11:53:00
Message-ID: CAKKotZRQzNVv=gKMFnc8ZNKaV_hJAnRFXWSbK-4mCLG6V0Bhpg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Yogesh,

I see one problem with the given solution, if a user opens two files from
two different locations with the same name but with different encoding then
the backend dict mapper (filename -> encoding) will be overridden by the
later filename.

--
Regards,
Murtuza Zabuawala
*EDB*
*POWER TO POSTGRES*
https://www.edbpostgres.com

On Mon, Aug 3, 2020 at 1:18 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Ensure that the original file format should be retained when saving the
> same file in SQL editor. Fixes #3767
>
> Branch
> ------
> master
>
> Details
> -------
>
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=43e127de3167311c4e65654cd1a6f2059ea14d50
> Author: Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com>
>
> Modified Files
> --------------
> docs/en_US/release_notes_4_25.rst | 1 +
> web/pgadmin/misc/file_manager/__init__.py | 7 +++++++
> web/pgadmin/tools/sqleditor/__init__.py | 12 +++++++++++-
> 3 files changed, 19 insertions(+), 1 deletion(-)
>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Yogesh Mahajan 2020-08-05 14:16:22 [pgAdmin4][Patch] - SonarQube Issues - 13 (String literals should not be duplicated)
Previous Message Nikhil Mohite 2020-08-05 11:19:10 Patch for SonarQube code scan fixes.