From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Fixed RM #1209 Trigger issues through right click |
Date: | 2016-08-24 05:55:44 |
Message-ID: | CAKKotZRGPOigsnhTH2Yp=49dxJz+VxxBh2j7cmX3hYcw_k2CPQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay,
Please address below minor issues & rest of the functionality is working.
1) In case of EPAS when user updates only code definition comment is not
updated along with it for from old trigger.
2) Resize the window size so that event labels in fieldset can render
properly.
Refer: server_groups.js for custom dialog size (width: '650px' should work)
Thanks,
Murtuza
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Tue, Aug 23, 2016 at 12:38 PM, Akshay Joshi <
akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
> Hi All
>
> While fixing RM #1209 I have found following of issues, that I have fixed
> as part of RM #1209
>
> - Trigger function is not displayed in the combo box for edit mode.
> - Change the font of the "fieldset > legend" from 16px to 14px in
> overrides.css, as it doesn't looks good.
> - When user set constraint trigger to "Yes" then Fires should be set
> to "AFTER", which is fixed.
> - Code tab is always disabled and empty. User won't be able to
> see/update the code for PPAS when Trigger function is "Inline EDB SPL".
> This issue is mentioned in the RM #1209.
>
> Attached is the patch file, please review it and let me know the review
> comments (if any)
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2016-08-24 06:07:11 | PATCH: id and pid is not being sent in response (pgAdmin4) |
Previous Message | Ashesh Vashi | 2016-08-24 05:55:31 | Re: PATCH/s: RM#1387 - Bad handling of missing connection database server |