Re: [pgAdmin4][Patch]: To fix the issue in File manager

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: To fix the issue in File manager
Date: 2017-12-06 05:33:01
Message-ID: CAKKotZQyt-QOQAHemEY=KFGau=3_Gx-r3i-ebK+Ziu5EjGz7+A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

I'm not able to re-produce the issue, I've updated the RM with my steps,
please check and let me know If I missed anything.
https://redmine.postgresql.org/issues/2937

-- Murtuza

On Wed, Dec 6, 2017 at 10:17 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> Thanks, applied. I noticed whilst testing that the Select button on the
> file dialogue can become enabled again following navigation to another
> directory. That then allows you to click it when no files are selected,
> which of course fails horribly.
>
> Can you take a look at that please? https://redmine.
> postgresql.org/issues/2937
>
> On Tue, Dec 5, 2017 at 10:20 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch to fix referenced before assignment bug in file manager.
>> RM#2934
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2017-12-06 05:45:05 [pgAdmin4][Patch]: Fixed RM #2779 - Lost field size
Previous Message Dave Page 2017-12-06 04:47:17 Re: [pgAdmin4][Patch]: To fix the issue in File manager