Re: [pgAdmin4][RM#3257] Fix for explain functionality

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM#3257] Fix for explain functionality
Date: 2018-04-10 17:57:57
Message-ID: CAKKotZQwdJX6w+9OW3HoGJUBDd+3yhLhW34uR7OtScXk2-HDoQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks for reviewing Joao.

Yeah missed to run tests. I assumed its just a SQL formatting it wouldn't
hurt anything but I was wrong :)
Here's updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Apr 10, 2018 at 8:18 PM, Joao De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:

> Hi Murtuza,
> Looks like the tests are failing due to this change.
> I also got some strange result on the linter, but I believe it is
> something related to this machine.
>
> Thanks
> Joao
>
> On Tue, Apr 10, 2018 at 6:20 AM Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> A minor fix for explain functionality.
>>
>> *Issue:* Due to multiline explain options in the SQL template CodeMirror
>> was failing to highlight the exact line of error.
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>

Attachment Content-Type Size
RM_3257_v1.diff application/octet-stream 5.9 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Rahul Soshte 2018-04-10 19:50:57 Ignoring web/yarn-error.log and runtime/moc_LogWindow.cpp
Previous Message Murtuza Zabuawala 2018-04-10 17:39:18 Re: [pgAdmin4] Changes required to support PyCrypto