From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: RM #3461 Properties/SQL panel contents does not updates when user perform Refresh operation on the node |
Date: | 2018-08-13 16:26:02 |
Message-ID: | CAKKotZQw1LBgGVc3+WL4YOoy84z0P75UsOuneZe9+B0Vr77H=Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay,
I've tested and found one issue,
*Steps:*
1) Expand to any Table (eg: 'abc') with a Trigger ('trig_on_abc')
2) Right click on that 'trig_on_abc' trigger and open "Properties" dialog,
Goto > "Definition" tab
3) Toggle the value of 'Trigger enabled?'
4) Go to the modified "SQL" tab and just copy the generated SQL & close the
dialog (do not save, just close it)
5) Open the "Query tool" on the same and paste the SQL from the previous
step and execute it (commit it)
6) Now again goto that 'trig_on_abc' in the browser tree and right click
and refresh.
7) You will see that icon is not getting updated on the "Refresh", though
I'm receiving proper icon in the response.
(Attaching the screenshot)
Expected: Let's say If I've disabled the Trigger via SQL then Disable
trigger icon should get reflected when we Refresh.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Aug 13, 2018 at 6:18 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Thanks, patch applied.
>
> On Mon, Aug 13, 2018 at 12:01 PM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix RM #3461 "Properties/SQL panel contents does
>> not updates when user perform Refresh operation on the node". Please review
>> it.
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachment | Content-Type | Size |
---|---|---|
Screen Shot 2018-08-13 at 9.48.09 PM.png | image/png | 185.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2018-08-13 16:30:23 | Re: [pgAdmin4][Patch]: RM #3461 Properties/SQL panel contents does not updates when user perform Refresh operation on the node |
Previous Message | Dave Page | 2018-08-13 12:48:31 | Re: [pgAdmin4][Patch]: RM #3461 Properties/SQL panel contents does not updates when user perform Refresh operation on the node |