Re: [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

Sure, Checking.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sat, Feb 4, 2017 at 7:34 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi Murtuza,
>
> I clearly neglected to run the regression tests with this patch, and
> unfortunately it looks like it broke them. Can you look at this ASAP
> please?
>
> runTest (pgadmin.browser.server_groups.servers.databases.
> schemas.tables.column.tests.test_column_add.ColumnAddTestCase)
> This function will add column under table node. (Add table Node URL)
> ... 2017-02-04 14:43:55,191: ERROR pgadmin: Failed to execute query
> (execute_scalar) for the server #4 - DB:test_db_9e176 (Query-id:
> 4792242):
> Error Message:ERROR: syntax error at or near "False"
> LINE 2: ADD COLUMN test_column_add_f0d5d char(False);
> ^
> FAIL
>
> As far as I can see, the app works fine - it's only the test that
> broke (probably because the application uses type name aliases (e.g.
> character) rather than the base type name that the test is using
> ("char").
>
> Thanks.
>
> On Fri, Feb 3, 2017 at 1:52 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> > Thanks - patch applied.
> >
> > On Fri, Feb 3, 2017 at 11:46 AM, Murtuza Zabuawala
> > <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> >> Hi,
> >>
> >> Please find updates patch for the same.
> >> RM#2076
> >>
> >> --
> >> Regards,
> >> Murtuza Zabuawala
> >> EnterpriseDB: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >>
> >> On Wed, Feb 1, 2017 at 3:08 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>>
> >>> Hi
> >>>
> >>> On Tue, Jan 31, 2017 at 5:19 AM, Murtuza Zabuawala
> >>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> >>> > Hi Dave,
> >>> >
> >>> > PFA updated patch.
> >>>
> >>> This seems to display "timestamp(0) with[out] timezone" columns
> >>> correctly in both the properties panel and dialog now, but the size is
> >>> still ignored if I try to add a new column through the table or column
> >>> dialogue.
> >>>
> >>> --
> >>> Dave Page
> >>> Blog: http://pgsnake.blogspot.com
> >>> Twitter: @pgsnake
> >>>
> >>> EnterpriseDB UK: http://www.enterprisedb.com
> >>> The Enterprise PostgreSQL Company
> >>
> >>
> >
> >
> >
> > --
> > Dave Page
> > Blog: http://pgsnake.blogspot.com
> > Twitter: @pgsnake
> >
> > EnterpriseDB UK: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>