Re: PATCH: To fix the issue in Database node (pgAdmin4)

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: George Gelashvili <ggelashvili(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix the issue in Database node (pgAdmin4)
Date: 2017-01-30 05:31:19
Message-ID: CAKKotZQiBFRD5DD1aGRLeHZvBEH_oAb-NVbGFVHHMi1gYpiH8w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

Please find updated patch, Tested against maintenance database as well.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jan 25, 2017 at 6:39 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Wed, Jan 25, 2017 at 12:21 PM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> >
> > Last patch had Python-3 fix for test suite, but now it is already
> committed.
> > PFA updated patch.
>
> It still doesn't work completely for me. I tried changing the value of
> bytea_output in a database that *does* allow connections, and I get a
> 503 response from the server, with a message of:
>
> {"info":"CONNECTION_LOST","errormsg":"Connection to the server has
> been lost!","data":{"database":null,"conn_id":null,"sid":1},"
> result":null,"success":0}
>
> The payload sent via PUT to
> http://127.0.0.1:5050/browser/database/obj/1/1/12403 was:
>
> {"id":12403,"variables":{"changed":[{"role":"pgweb","
> name":"bytea_output","value":"hex","database":"postgres"}]}}
>
> It works fine without the patch applied.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
RM_2024_v4.patch application/octet-stream 10.3 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2017-01-30 05:37:37 [pgAdmin4][PATCH] To fix the issue in handling of timestamp type
Previous Message Murtuza Zabuawala 2017-01-30 05:26:57 Re: [Patch] Refactor sql template version picking