Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

Hi Harshal,

Could you please look at the latest issue reported by user on
https://redmine.postgresql.org/issues/2258#change-8312
It looks like regression of RM#2671 changes.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Sep 18, 2017 at 12:07 PM, Akshay Joshi <
akshay(dot)joshi(at)enterprisedb(dot)com> wrote:

> Thanks patch applied.
>
> On Fri, Sep 15, 2017 at 6:16 PM, Harshal Dhumal <
> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
>> Hi Akshay,
>>
>> It's not issue; Try without quotes. As char data type stores only one
>> character so it's storing only leading quote (') and
>> truncating remaining characters (a').
>> Only exception is when you want to store empty string (char) use two
>> quotes (either single or double)
>> they will translated before sending to server.
>>
>> Apart from this I found that data types "char" and "char"[] (alias to
>> character and character[] respectively)
>> were not taken into consideration in sqleditor.js. I have attached
>> updated patch which fixes this issue.
>>
>>
>>
>>
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Thu, Sep 14, 2017 at 5:31 PM, Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Harshal
>>>
>>> I have reviewed your patch it looks good to me. Only one issue I have
>>> found with char[], when I store {'a','b','c'} it gets stored and when I
>>> refreshed it shows {',','}. Please look into this issue.
>>>
>>> On Thu, Sep 14, 2017 at 3:54 PM, Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> It works, sorry for the noise.
>>>>
>>>> On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <
>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Harshal,
>>>>>
>>>>> Can you please rebase the patch, it's not applied with the latest code.
>>>>>
>>>>> On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <
>>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Tue, Sep 12, 2017 at 2:34 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>>
>>>>>>> Adding Akshay...
>>>>>>>
>>>>>>
>>>>>> Sure.
>>>>>>
>>>>>>>
>>>>>>> On Tue, Sep 12, 2017 at 10:04 AM, Dave Page <dpage(at)pgadmin(dot)org>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Akshay, can you review/commit this please?
>>>>>>>>
>>>>>>>> On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <
>>>>>>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> Please find attached patch to represent array data in datagrid
>>>>>>>>> with curly braces and
>>>>>>>>> also allow user to save array with values like <null>, <empty
>>>>>>>>> string>, '*""*' and "*''*"
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> *Harshal Dhumal*
>>>>>>>>> *Sr. Software Engineer*
>>>>>>>>>
>>>>>>>>> EnterpriseDB India: http://www.enterprisedb.com
>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>> Twitter: @pgsnake
>>>>>>>>
>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>> Twitter: @pgsnake
>>>>>>>
>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Akshay Joshi*
>>>>>> *Principal Software Engineer *
>>>>>>
>>>>>>
>>>>>>
>>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Akshay Joshi*
>>>>> *Principal Software Engineer *
>>>>>
>>>>>
>>>>>
>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> *Akshay Joshi*
>>>> *Principal Software Engineer *
>>>>
>>>>
>>>>
>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>> *Principal Software Engineer *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>