From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Suggestion on "External types" sql query in pgAdmin3 |
Date: | 2016-03-21 10:55:11 |
Message-ID: | CAKKotZQTOHFskPE4VKiYrMpo8_aFumkyNOM-ji-Mqc3F=Snwjg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi All,
Below is the query to fetch Input/Output/Send/Receive/Analyze functions
while creating new external type (create mode) in pgAdmin3,
With latest git pull [File: pgadmin/dlg/dlgType.cpp] [Line: 548],
*Current:*
SELECT proname, nspname
FROM (
SELECT proname, nspname, max(proargtypes[0]) AS arg0, max(proargtypes[1])
AS arg1
FROM pg_proc p
JOIN pg_namespace n ON n.oid=pronamespace
GROUP BY proname, nspname
HAVING count(proname) = 1 ) AS uniquefunc
WHERE arg0 <> 0 AND *arg1 = 0*;
*Modified: *SELECT proname, nspname
FROM (
SELECT proname, nspname, max(proargtypes[0]) AS arg0, max(proargtypes[1])
AS arg1
FROM pg_proc p
JOIN pg_namespace n ON n.oid=pronamespace
GROUP BY proname, nspname
HAVING count(proname) = 1 ) AS uniquefunc
WHERE arg0 <> 0 AND *arg1 IS NULL*;
When I changed where condition to 'arg1 IS NULL' from 'arg1 = 0', All combo
boxes are populated.
Can someone please confirm if it's correct?
Please review attached patch for the same.
Regards,
Murtuza
Attachment | Content-Type | Size |
---|---|---|
Fixed_types_query_v1.patch | text/x-patch | 533 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-03-21 14:33:27 | Re: Fix PSQL Console plugin for OS X |
Previous Message | Khushboo Vashi | 2016-03-21 07:41:34 | Re: pgAdmin4 PATCH: Domain Module |