Re: pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317
Date: 2018-03-15 10:33:32
Message-ID: CAKKotZQRm4xwt60MzV8uMc10-_SaRVbnb0kyMFzf7wq=PcmUZQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Akshay,

Given commit introduce PEP8 issue, PFA minor patch to fix the issue.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Mar 15, 2018 at 1:27 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

> Sporadically crashes on Windows when exit. Fixes #3177
> 1) Shutdown the python server properly.
> 2) Disabled "Shutdown server" menu till server is not successfully
> started.
>
> Initial patch sent by Maxim, modified by Akshay Joshi.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 54b1a79cb6f90ac9b26db57e616dc750fb2c6b54
> Author: Maxim Zakharov <dp(dot)maxime(at)gmail(dot)com>
>
> Modified Files
> --------------
> runtime/Server.cpp | 11 +++++++++++
> runtime/Server.h | 3 +++
> runtime/TrayIcon.cpp | 11 +++++++++++
> runtime/TrayIcon.h | 4 ++++
> runtime/pgAdmin4.cpp | 46 ++++++++++++++++++++++++++++++
> ++++++++++++++
> runtime/pgAdmin4.h | 1 +
> web/pgadmin/misc/__init__.py | 16 ++++++++++++++-
> 7 files changed, 91 insertions(+), 1 deletion(-)
>
>

Attachment Content-Type Size
fix_PEP8.diff application/octet-stream 462 bytes

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2018-03-15 10:43:18 pgAdmin 4 commit: Fixed PEP8 issue
Previous Message fred.escallier 2018-03-15 10:08:22 French translation