Re: [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries
Date: 2017-02-06 10:33:49
Message-ID: CAKKotZQR00uYGKfEgbPzH=qLGL1aFu0h5ioyxmqhUucn2c98Ew@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

With Same query I am getting proper output same as pgAdmin3.
Can you hard refresh browser & try again?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Feb 6, 2017 at 3:31 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Mon, Feb 6, 2017 at 5:40 AM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > PFA patch to fix the issue with Graphical Explain plan functionality
> which
> > was breaking for INSERT/UPDATE/DELETE explain plans.
> > RM#2133
> >
> > Issue: It was due to typo in imageMapper object.
> >
> > Please review.
>
> It's a definite improvement, but still isn't quite right - see the
> attached screenshot for example; the node name should be pem.agent
> shouldn't it (or 'Delete' or 'Delete from pem.agent')?
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
Screen Shot 2017-02-06 at 4.01.37 pm.png image/png 188.0 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-02-06 10:43:35 pgAdmin 4 commit: Fix display of graphical query plans for UPDATE/DELET
Previous Message Dave Page 2017-02-06 10:32:18 Re: Acceptance Tests against a browser (WIP)