Re: [PATCH] Tables node (pgAdmin4)

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Tables node (pgAdmin4)
Date: 2016-05-17 09:22:13
Message-ID: CAKKotZQPLM-9t_WjJfWqdaLfkj9LkopUR3RgoCTbBBB0NBaHdg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

PFA add-on patch to Ver.6 patch, Which will add CREATE/SELECT etc Script
support into table node.

Regards,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, May 17, 2016 at 11:48 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find attached add-on patch for table's subnode rule.
> Apply this patch at end after applying previous patches in email thread.
>
> *Issue fixed*: "Do Instead" on Rule node under View/M-View node not
> working in properties mode. Unable to generate proper SQL.
>
> On Mon, May 16, 2016 at 7:02 PM, Harshal Dhumal <
> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA add-on patch for table and it's child node. (please apply this patch
>> on version 6 patch)
>>
>> Murtuza and I fixed following issues:
>>
>> 1. SQL formatting
>> 2. Vacuum grid should not be editable in properties mode.
>> 3. Column datatype does not get displayed in the properties and edit mode.
>> 4. Do not allow to add another primary key if one already exist.
>>
>> And another minor enhancements.
>>
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer *
>>
>>
>>
>> EenterpriseDB <http://www.enterprisedb.com>
>>
>> On Sat, May 14, 2016 at 2:03 AM, Harshal Dhumal <
>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>
>>>
>>> Hi,
>>>
>>>
>>> PFA updated patches (version: 6) for table and it's child nodes.
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Software Engineer *
>>>
>>>
>>>
>>> EenterpriseDB <http://www.enterprisedb.com>
>>>
>>> On Fri, May 13, 2016 at 6:55 PM, Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Review Comments:
>>>>
>>>> - Please replace 'can not' with 'cannot' in all the validation
>>>> messages.
>>>> - PG 9.1+ Inheritance issue as below:
>>>>
>>>> CREATE TABLE public.table1
>>>> (
>>>> )
>>>> (
>>>> )
>>>> INHERITS (a)
>>>> WITH (
>>>> OIDS = FALSE
>>>> )
>>>> TABLESPACE pg_default;
>>>> ALTER TABLE public.table1
>>>> OWNER to postgres;
>>>>
>>>>
>>>> brackets are coming twice.
>>>>
>>> Fixed
>>>
>>>
>>>>
>>>> - Please maintain one line spacing between SQL queries In the SQL Tab.
>>>>
>>> TODO
>>>
>>>
>>>> - Foreign Key Grid in Table css issue: Grid columns expands on the
>>>> selection of the cell
>>>>
>>> Fixed
>>>
>>>
>>>> - Check Constraint: Validated? option should be True by default
>>>>
>>> Not sure about this. I cross checked in pgadmin3.
>>>
>>>
>>>
>>>> - pg 9.4: Exclude constraint does not render in SQL tab
>>>>
>>> Fixed
>>>
>>>
>>>> - Missing Security validation
>>>>
>>> Fixed
>>>
>>>
>>>> - Vacuum grid should not be editable in properties mode.
>>>>
>>> TODO (It's editable but one cannot save it on server from here as there
>>> is no save button.)
>>>
>>>
>>>> - Edit mode, Fill Factor can be allowed to be null.
>>>>
>>> TODO (This is generic issue in Integer and Numeric controls. This issue
>>> is covered in this partial patch
>>> <http://www.postgresql.org/message-id/CAFiP3vzvtqxJMpZeeaV4pd0p7CevcRRDfgDWuvu4cyHNThpJFQ@mail.gmail.com>
>>> )
>>>
>>>
>>>> - While dropping inheritance, related table columns drop SQL are also
>>>> populated in the SQL Tab
>>>>
>>>> ALTER TABLE public."Tbl"
>>>> NO INHERIT b;
>>>> ALTER TABLE public."Tbl" DROP COLUMN id;
>>>> ALTER TABLE public."Tbl" DROP COLUMN name;
>>>>
>>>>
>>> Fixed
>>>
>>>
>>>
>>>>
>>>> And also render error while clicking on the save button.
>>>>
>>>> ERROR: syntax error at or near "["
>>>> LINE 2: INHERIT [;
>>>>
>>>> ^
>>>>
>>>> Fixed
>>>
>>>
>>>> - in a Reverse Engineering SQL tab, schema_name.tablename should be
>>>> there, currently only table_name displays.
>>>>
>>> Fixed
>>>
>>>
>>>
>>>> - Column SQL is showing below text with HTML
>>>>
>>>>
>>>> <html><head></head><body>-- Column: id -- ALTER TABLE public.a DROIP
>>>> COLUMN id; ALTER TABLE public.a ADD COLUMN id integer;</body></html>
>>>>
>>>>
>>> I was not able to reproduce exact issue but still I have fixed other
>>> issue which I found related to column SQL. Hopefully that will fix this
>>> issue as well.
>>>
>>>
>>>> - The column datatype dependency does not get cleared upon selection of
>>>> another datatype.
>>>>
>>> For example, if I select numeric and gives the length and precision.
>>>> After that I change the dat-type then, dependent fields should be get
>>>> cleared.
>>>>
>>> Fixed.
>>>
>>>
>>>>
>>>> - The column datatype does not get displayed in the properties and edit
>>>> mode if the length and precision are given while creating a column.
>>>>
>>>
>>> TODO ( I cannot fix this blindly as this might introduce another
>>> issue(s) in column node. I will need Murtuza's help as he has worked on
>>> column node)
>>>
>>>
>>>>
>>>> - Statistics is showing null value even after having value.
>>>>
>>> Fixed
>>>
>>>
>>>>
>>>> - if the check constraints are not validated then put proper icon in
>>>> tree and also it should be validated in edit mode.
>>>>
>>> Not reproducible.
>>>
>>>
>>>>
>>>> NOTE: I have not checked the Indexes, Triggers and Rules nodes as I do
>>>> not have much knowledge about it.
>>>>
>>>>
>>>
>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>> On Fri, May 13, 2016 at 5:24 PM, Harshal Dhumal <
>>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> PFA attached patches for table and it's child nodes with python 2.7
>>>>> compatibility.
>>>>>
>>>>>
>>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

Attachment Content-Type Size
Added_CREATE_Script_on_Table_v8.patch application/octet-stream 7.9 KB

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-05-17 09:24:10 Re: PATCH: CREATE Script Initial patch (pgAdmin4)
Previous Message Harshal Dhumal 2016-05-17 07:24:07 Re: PATCH: FTS configuration node