Re: pgAdmin 4 commit: Fixed an issue where the validation error message is

Hello,

Another observation,

+ if(msg && handler) {
+ msg = msg || _.values(handler.errorModel.attributes)[0];
+
+ handler.trigger('pgadmin-session:model:invalid', msg, handler);
+ $(parentTr).addClass('error-in-grid');
+ }
+ return this;
+ }, 120);
+ },

Here we are only making the model invalid, there is no logic to make it
valid again.

On Thu, Dec 3, 2020 at 11:09 AM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hello,
>
> What is the reason for adding delay *setTimeout(<func>, 120)*?
>
> This is causing issues in automation testing and makes buttons
> enable/disable with slight delay.
>
> --
> Regards,
> Murtuza Zabuawala
> *EDB*
> *POWER TO POSTGRES*
> https://www.edbpostgres.com
>
>
> On Fri, Oct 30, 2020 at 3:10 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Fixed an issue where the validation error message is shown twice. Fixes
>> #5736
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>>
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=183c83f0d2b2cb8dd33f9e8c41a030bc4cdaa4b2
>> Author: Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com>
>>
>> Modified Files
>> --------------
>> docs/en_US/release_notes_4_28.rst | 1 +
>> web/pgadmin/browser/static/js/datamodel.js | 75
>> +++++++++++++++++++++++++++++-
>> web/pgadmin/static/js/backform.pgadmin.js | 24 ++++------
>> web/pgadmin/static/scss/_alert.scss | 6 +++
>> 4 files changed, 90 insertions(+), 16 deletions(-)
>>
>>