Re: PATCH: To fix the issue in Debugger module (pgAdmin4)

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix the issue in Debugger module (pgAdmin4)
Date: 2016-09-26 12:28:16
Message-ID: CAKKotZQGdhiFrtNK0xz8OVLKOA2QCk_yfOZDFT+HEMfELzbk4A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

PFA updated patch to fix `<br>` tag display.
Please clear cache & try again with this updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Sep 26, 2016 at 5:44 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

>
>
> On Mon, Sep 26, 2016 at 5:08 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Mon, Sep 26, 2016 at 11:09 AM, Murtuza Zabuawala
>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>> > Hi,
>> >
>> > PFA patch to fix the issue where it was not disabling buttons after
>> > execution gets finished.
>> > RM#1227
>> >
>> > Issue:
>> > If user clicks on buttons after execution is complete then it was
>> throwing
>> > error, expected behaviour was all button should gets disabled except
>> execute
>> > button.
>>
>> This is an improvement I think, but not complete:
>>
>> - The info messages are now shown, but:
>> - Not until execution ends, which limits their usefulness for
>> additional debugging. Not sure if that's easily changeable though.
>
> - The line breaks in messages are displaying like this: "INFO:
>> Employee 1 not found <br>SELECT 1"
>>
> It's showing properly on my side, Please clear browser cache & try again.
>
>> - The first execution of the function worked OK, but following the
>> second execution, I again saw: "Debugger: Step into execution error"
>> as I stepped out of the RETURN statement on line 18.
>>
> This is transient issue, so need more debugging.
>
>
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

Attachment Content-Type Size
RM_1227_v1.patch application/octet-stream 3.4 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-09-26 12:43:16 pgAdmin 4 commit: pgAgent misc fixes:
Previous Message Murtuza Zabuawala 2016-09-26 12:14:03 Re: PATCH: To fix the issue in Debugger module (pgAdmin4)