Re: Update LDAP Protocol in fe-connect.c to v3

Here is the same patch as v2 but with "const" removed in case you want to
move forward with that change. Tested locally against the tests I wrote in
the other patch to sanity check the change.

On Thu, Apr 3, 2025 at 8:42 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> > Here is a slightly polished version of this patch. I added an error
> > message, and changed the return code, but it's a bit confusing which one
> > might be the right one.
>
> I'm kind of -0.5 on declaring the variable as "const", because none of
> our existing calls of ldap_set_option do that. I do see that the
> Linux man page for ldap_set_option claims that that argument can be
> const, but I think you're risking a portability gotcha for no large
> gain. LGTM otherwise.
>
> > My hunch right now is that we should probably take the patch that sets
> > the version option and consider it for backpatching. The patch with the
> > tests can be held for detailed review later.
>
> +1 for that plan.
>
> regards, tom lane
>