Re: Bogus lateral-reference-propagation logic in create_lateral_join_info

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Bogus lateral-reference-propagation logic in create_lateral_join_info
Date: 2019-02-06 01:26:30
Message-ID: CAKJS1f_j1JMQsdX+LODUywNT0WqAy6L_eF+5oZQ4FkJ_afCLMQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 6 Feb 2019 at 10:57, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Also, I'd really like to know why I had to put in the exception seen
> in the loop for AppendRelInfos that do not point to a valid parent.
> It seems to me that that is almost certainly working around a bug in
> the partitioning logic. (Without it, the partition_prune regression test
> crashes.) Or would somebody like to own up to having created that state
> of affairs intentionally? If so why?

Sounds pretty strange to me. What exactly do you mean by not
pointing to a valid parent? Do you mean the parent_relid index is not
a valid RelOptInfo?

Can you point to the regression test that's doing this?

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-02-06 01:35:12 Re: Refactoring IndexPath representation of index conditions
Previous Message Alvaro Herrera 2019-02-06 01:21:40 Re: [HACKERS] PATCH: multivariate histograms and MCV lists