| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Custom table AMs need to include heapam.h because of BulkInsertState |
| Date: | 2019-08-14 06:11:06 |
| Message-ID: | CAKJS1f_ZQLCEnmSRZwnbs4xw8VDvh7L2sOoA6oNzhUOQ_ZFm0Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 17 Jul 2019 at 06:46, Andres Freund <andres(at)anarazel(dot)de> wrote:
> 2) Add a execPartition.c function that returns all the used tables from
> a PartitionTupleRouting*.
Here's a patch which implements it that way.
I struggled a bit to think of a good name for the execPartition.c
function. I ended up with ExecGetRoutedToRelations. I'm open to better
ideas.
I also chose to leave the change of function signatures done in
f7c830f1a in place. I don't think the additional now unused parameter
is that out of place. Also, the function is inlined, so removing it
wouldn't help performance any.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| call_table_finish_bulk_insert_less_often.patch | application/octet-stream | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alex | 2019-08-14 06:33:54 | use valgrind --leak-check=yes to detect memory leak |
| Previous Message | Peter Eisentraut | 2019-08-14 05:59:16 | use of the term "verifier" with SCRAM |