| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Clarify use of temporary tables within partition trees |
| Date: | 2018-06-29 09:13:28 |
| Message-ID: | CAKJS1f_HyV1txn_4XSdH5EOhBMYaCwsXyAj6bHXk9gOu4JKsbw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 20 June 2018 at 13:53, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Clarify use of temporary tables within partition trees
Hi,
Thanks for committing this fix.
I think slightly more should have been done. There's still some dead
code in expand_partitioned_rtentry that I think should be removed.
The code won't cost much performance wise, but it may mislead someone
into thinking they can add some other condition there to skip
partitions.
The attached removes it.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| remove_dead_code_from_expand_partitioned_rtentry.patch | application/octet-stream | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-06-29 12:04:07 | Re: Tips on committing |
| Previous Message | Tom Lane | 2018-06-29 03:53:10 | Re: pgsql: Fix "base" snapshot handling in logical decoding |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-06-29 09:34:26 | Re: Regression on PostgreSQL 10 ORDER/GROUP BY expression not found in targetlist |
| Previous Message | Юрий Соколов | 2018-06-29 09:07:47 | Re: [WIP] [B-Tree] Retail IndexTuple deletion |