| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Tighten up a few overly lax regexes in pg_dump's tap tests |
| Date: | 2019-02-05 04:46:55 |
| Message-ID: | CAKJS1f_7nqRYE+vTtRjEwy2WZBkKo=PmfjTxT3+Q=Jb0f24sbg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 5 Feb 2019 at 14:41, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Instead of the approach you are
> proposing, perhaps it would make sense to extend this way of doing
> things then? For example some tests with CREATE CONVERSION do so. It
> looks much more portable than having to escape every dot.
I'm not particularly excited either way, but here's a patch with it that way.
I did leave a couple untouched as there was quite a bit of escaping
going on already. I didn't think switching between \Q and \E would
have made those ones any more pleasing to the eye.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| tighten_up_pg_dump_tap_tests_v2.patch | application/octet-stream | 11.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2019-02-05 04:53:54 | Re: Tighten up a few overly lax regexes in pg_dump's tap tests |
| Previous Message | David Rowley | 2019-02-05 04:15:54 | Re: Inadequate executor locking of indexes |