| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Sergei Kornilov <sk(at)zsrv(dot)org> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ildar Musin <i(dot)musin(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: using index or check in ALTER TABLE SET NOT NULL |
| Date: | 2019-03-11 03:30:31 |
| Message-ID: | CAKJS1f_+T_y2sDPz8ZPB7wUi7Ob-aO6iaUbd1KOx2-K+tksk=Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 11 Mar 2019 at 00:13, Sergei Kornilov <sk(at)zsrv(dot)org> wrote:
>
> > Providing I'm imagining it correctly, I do think the patch is slightly
> > cleaner with that change.
>
> Ok, sounds reasonable. I changed patch this way.
Looks good to me. Good idea to keep the controversial setting of
client_min_messages to debug1 in the tests in a separate patch.
Apart from a few lines that need to be wrapped at 80 chars and some
comment lines that seem to have been wrapped early, I'm happy for it
to be marked as ready for committer, but I'll defer to Ildar in case
he wants to have another look.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-03-11 03:54:28 | Re: Portability of strtod (was Re: pgsql: Include GUC's unit, if it has one, in out-of-range error message) |
| Previous Message | Tom Lane | 2019-03-11 03:15:40 | Portability of strtod (was Re: pgsql: Include GUC's unit, if it has one, in out-of-range error message) |