| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Confusing error message for REINDEX TABLE CONCURRENTLY |
| Date: | 2019-06-05 09:08:46 |
| Message-ID: | CAKJS1f9y-OH+3yikdBBAYZ_2r2KN2vE9sODhD5eKnq0+u=a8eA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 5 Jun 2019 at 18:11, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Jun 04, 2019 at 11:26:44AM -0700, Ashwin Agrawal wrote:
> > The variable is used in else scope hence I moved it there. But yes its
> > removed completely for this scope.
>
> Thanks for updating the patch. It does its job by having one separate
> message for the concurrent and the non-concurrent cases as discussed.
> David, what do you think? Perhaps you would like to commit it
> yourself?
Thanks. I've just pushed this with some additional comment changes.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-06-05 11:03:48 | Re: hyrax vs. RelationBuildPartitionDesc |
| Previous Message | Christoph Berg | 2019-06-05 08:47:35 | Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.) |