| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to improve performance of replay of AccessExclusiveLock |
| Date: | 2017-03-08 02:02:17 |
| Message-ID: | CAKJS1f9n=9UuROdMygBwVhm=95mZBJ9FWuBqEKWAZRUt3vs2Yw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8 March 2017 at 01:13, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> Don't understand this. I'm talking about setting a flag on
> commit/abort WAL records, like the attached.
There's nothing setting a flag in the attached. I only see the
checking of the flag.
> We just need to track info so we can set the flag at EOXact and we're done.
Do you have an idea where to store that information? I'd assume we'd
want to store something during LogAccessExclusiveLocks() and check
that in XactLogCommitRecord() and XactLogAbortRecord(). I don't see
anything existing which might help with that today. Do you think I
should introduce some new global variable for that? Or do you propose
calling GetRunningTransactionLocks() again while generating the
Commit/Abort record?
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-03-08 02:03:53 | Re: Skip all-visible pages during second HeapScan of CIC |
| Previous Message | Craig Ringer | 2017-03-08 01:56:40 | Re: PATCH: Batch/pipelining support for libpq |