Re: BUG #15245: pg_stat_all_tables does not include partition master tables

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: mahadevan(at)rapidloop(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15245: pg_stat_all_tables does not include partition master tables
Date: 2018-06-18 05:49:47
Message-ID: CAKJS1f9cAMbXym0UE0U_Zfg_qEdnm=RJWPDnEHdU5o3vAGE2Kg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 17 June 2018 at 20:54, PG Bug reporting form <noreply(at)postgresql(dot)org> wrote:
> The system view pg_catalog.pg_stat_all_tables (and therefore also
> pg_catalog.pg_stat_user_tables) do not list partition master tables (CREATE
> TABLE ... PARTITION BY ..).
>
> This is because it only includes rows from pg_class with relkind IN ('r',
> 't', 'm') (as defined in src/backend/catalog/system_views.sql).
>
> IMHO, it should also include rows with relkind = 'p'.

FWIW there was a similar discussion of whether
pg_relation_size('<partitioned table>') should report the sizes of all
its partitions in [1]. Most people seemed to vote to leave it
returning 0.

Some of the same reasoning might apply to this case.

[1] https://www.postgresql.org/message-id/495cec7e-f8d9-7e13-4807-90dbf4eec4ea@lab.ntt.co.jp

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2018-06-18 06:05:30 Re: BUG #15245: pg_stat_all_tables does not include partition master tables
Previous Message Michael Paquier 2018-06-18 02:06:42 Re: BUG #15245: pg_stat_all_tables does not include partition master tables