Re: Internal error XX000 with enable_partition_pruning=on, pg 11 beta1 on Debian

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Phil Florent <philflorent(at)hotmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Internal error XX000 with enable_partition_pruning=on, pg 11 beta1 on Debian
Date: 2018-07-19 13:06:17
Message-ID: CAKJS1f90XURZRA+ejnWByDufXHAwaULSLys3F+B1mK0hNjsPtQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 18 July 2018 at 06:01, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> On 2018-Jul-16, David Rowley wrote:
>
>> On 16 July 2018 at 12:55, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
>> > Thinking about this some more, I don't quite see any reason that the
>> > partitioned_rels for a single hierarchy couldn't just be a Bitmapset
>> > instead of an IntList.
>>
>> Of course, this is not possible since we can't pass a List of
>> Bitmapsets to the executor due to Bitmapset not being a node type.
>
> Maybe we can just add a new node type that wraps a lone bitmapset. The
> naive implementation (just print out individual members) should be
> pretty straightforward; a more sophisticated one (print out the "words")
> may end up more compact or not depending on density, but much harder for
> debugging, and probably means a catversion bump when BITS_PER_BITMAPWORD
> is changed, so probably not a great idea anyway.
>
> I suppose the only reason we haven't done this yet is nobody has needed
> it. Sounds like its time has come.

I don't mind doing the work if that's what's wanted, but I'd rather
wait for Tom to provide a bit more input into this as he seems to have
some ideas that I don't understand well enough to write code for.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2018-07-19 13:13:18 Re: pgsql: Fix parallel index and index-only scans to fall back to serial.
Previous Message David Rowley 2018-07-19 13:03:28 Re: Internal error XX000 with enable_partition_pruning=on, pg 11 beta1 on Debian