Re: Incorrect format in error message

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Incorrect format in error message
Date: 2016-04-01 07:18:29
Message-ID: CAKJS1f8znV8ZJDwxgJJ2TYgDHoNFFSeSkR-C78yOkpmKTKzaAQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1 April 2016 at 17:30, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
>> The attached fixes an error message which is incorrectly using an
>> unsigned format specifier instead of a signed one.
>
> Really though, what
> astonishes me about this example is that we allow indexes at all on
> system columns other than OID. None of the other ones can possibly
> have either a use-case or sensible semantics, can they? We certainly
> would not stop to update indexes after changing xmax, for example.

As for this part. I really don't see how we could disable this without
breaking pg_restore for database who have such indexes. My best
thought is to add some sort of warning during CREATE INDEX, like we do
for HASH indexes.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-04-01 07:30:08 Re: Incorrect format in error message
Previous Message Amit Kapila 2016-04-01 07:05:44 Re: OOM in libpq and infinite loop with getCopyStart()