Re: pg_dump is broken for partition tablespaces

On Thu, 7 Mar 2019 at 05:17, Andres Freund <andres(at)anarazel(dot)de> wrote:
> I'm also concerned that the the current catalog representation isn't
> right. As I said:
>
> > I also find it far from clear that:
> > <listitem>
> > <para>
> > The <replaceable class="parameter">tablespace_name</replaceable> is the name
> > of the tablespace in which the new table is to be created.
> > If not specified,
> > <xref linkend="guc-default-tablespace"/> is consulted, or
> > <xref linkend="guc-temp-tablespaces"/> if the table is temporary. For
> > partitioned tables, since no storage is required for the table itself,
> > the tablespace specified here only serves to mark the default tablespace
> > for any newly created partitions when no other tablespace is explicitly
> > specified.
> > </para>
> > </listitem>
> > is handled correctly. The above says that the *specified* tablespaces -
> > which seems to exclude the default tablespace - is what's going to
> > determine what partitions use as their default tablespace. But in fact
> > that's not true, the partitioned table's pg_class.retablespace is set to
> > what default_tablespaces was at the time of the creation.

Do you think it's fine to reword the docs to make this point more
clear, or do you see this as a fundamental problem with the patch?

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services