Re: EXPLAIN VERBOSE with parallel Aggregate

On 27 April 2016 at 14:30, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Apr 26, 2016 at 9:56 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Tue, Apr 26, 2016 at 9:14 PM, David Rowley
>> <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
>>> I'd also have expected the output of both partial nodes to be the
>>> same, i.e. both prefixed with PARTIAL. Is it intended that they don't?
>>> or have I made some other mistake?
>>
>> No, that's a defect in the patch. I didn't consider that we need to
>> support nodes with finalizeAggs = false and combineStates = true,
>> which is why that ERROR was there. Working on a fix now.
>
> I think this version should work, provided you use
> partial_grouping_target where needed.

+static void get_special_variable(Node *node, deparse_context *context,
+ void *private);

"private" is reserved in C++? I understood we want our C code to
compile as C++ too, right? or did I get my wires crossed somewhere?

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services