| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Tighten up a few overly lax regexes in pg_dump's tap tests |
| Date: | 2019-02-05 00:50:50 |
| Message-ID: | CAKJS1f8gMnUHoRD46twuLG1jz5yN1yukQ4JfSP9e+0SLy5Ko0Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 5 Feb 2019 at 13:15, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Some tests are missing the update, and it seems to me that
> tightening things up is a good thing, still we ought to do it
> consistently. Some places missing the update:
> - ALTER OPERATOR FAMILY
> - ALTER OPERATOR CLASS
> - ALTER SEQUENCE
> - ALTER TABLE (ONLY, partitioned table)
> - BLOB load
> - COMMENT ON
> - COPY
> - INSERT INTO
> - CREATE COLLATION
I think I've done all the ones that use \E. Those \Q ones don't need
any escaping. I assume that's the ones you've found. I didn't do an
exhaustive check though.
> test_pg_dump's 001_base.pl needs also a refresh.
Yeah, I thought about looking, but I thought it might be a bottomless pit.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-02-05 01:41:19 | Re: Tighten up a few overly lax regexes in pg_dump's tap tests |
| Previous Message | Michael Paquier | 2019-02-05 00:15:06 | Re: Tighten up a few overly lax regexes in pg_dump's tap tests |