Re: pgsql: Remove surplus call to table_finish_bulk_insert

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Rowley <drowley(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove surplus call to table_finish_bulk_insert
Date: 2019-07-01 15:46:19
Message-ID: CAKJS1f8f=vPMw_zcqvsCRLVq0ep-jNsuANeuyNufFxhq0yvJbA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, 2 Jul 2019 at 03:33, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <drowley(at)postgresql(dot)org> writes:
> > Remove surplus call to table_finish_bulk_insert
>
> This still blows up immediately with -DRELCACHE_FORCE_RELEASE
> (cf prion).
>
> I think at this point you should revert and try again later.
> This is blocking making the v12 branch, and it obviously needs
> more thought.

Yeah, you're right :( done.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-07-01 16:09:12 pgsql: Doc: remove obsolete description of oid column as being "hidden"
Previous Message David Rowley 2019-07-01 15:45:38 pgsql: Revert fix missing call to table_finish_bulk_insert during COPY