Re: pgsql: Change error handling of out of scope variables in ecpg.

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Michael Meskes <meskes(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Change error handling of out of scope variables in ecpg.
Date: 2019-01-30 17:52:04
Message-ID: CAKJS1f8N9r74qhA2LHss4Ub+-KssOwT_kK2bcFrPg1E-jWMOyA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, 31 Jan 2019 at 02:38, Michael Meskes <meskes(at)postgresql(dot)org> wrote:
> Change error handling of out of scope variables in ecpg.
>
> The function called can result in an out of memory error that subsequently was
> disregarded. Instead it should set the appropriate SQL error variables and be
> checked by whatever whenever statement is defined.

I might be missing something here, but if you're changing the
signature of output_simple_statement(), wouldn't you also need to
change all calls to it too? ... including the ones in preproc.y?

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-01-30 17:59:21 Re: pgsql: Change error handling of out of scope variables in ecpg.
Previous Message Peter Eisentraut 2019-01-30 13:47:08 Re: pgsql: Fix a crash in logical replication