| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Further simplification of c.h's #include section |
| Date: | 2017-11-16 12:40:44 |
| Message-ID: | CAKJS1f8DkZy4bupPtCjramXj+MKqA1WQPy_YtfT_8VTjoZSR-g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 16 November 2017 at 19:14, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> On Thu, Nov 16, 2017 at 2:23 PM, David Rowley
> <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
>> I do get some warnings:
>>
>> (ClCompile target) ->
>> src/test/modules/test_session_hooks/test_session_hooks.c(112): warning
>> C4113: 'void (__cdecl *)()' differs in parameter lists from
>> 'session_start_hook_type' [test_session_hooks.vcxproj]
>> src/test/modules/test_session_hooks/test_session_hooks.c(113): warning
>> C4113: 'void (__cdecl *)()' differs in parameter lists from
>> 'session_end_hook_type' [test_session_hooks.vcxproj].
>>
>> 2 Warning(s)
>>
>> But I imagine that was caused by 745948422c (also get the warnings without
>> your patch)
>
> Do the warnings go away with the patch attached?
Yes
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 高增琦 | 2017-11-16 12:50:31 | Re: no library dependency in Makefile? |
| Previous Message | Stephen Frost | 2017-11-16 12:18:23 | Re: pgsql: Add hooks for session start and session end |