From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: RelationGetIndexAttrBitmap() small deviation between comment and code |
Date: | 2019-01-21 23:51:47 |
Message-ID: | CAKJS1f8DVqeyEUuZi=wqOHbQC+DcPQSY3wbpNTZu8f-ACSv-WA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, 22 Jan 2019 at 12:27, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> > (This is pretty minor, but I struggled to ignore it)
> > In RelationGetIndexAttrBitmap() a comment claims /* We return our
> > original working copy for caller to play with */. 3 of the 4 possible
> > Bitmapsets follow that comment but for some reason, we make a copy of
> > the primary key attrs before returning. This seems both unnecessary
> > and also quite out of sync to what all the other Bitmapsets do. I
> > don't quite see any reason for doing it so I assume there's none.
>
> I agree, that's pretty bogus. Will push in a minute.
Thanks.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-01-21 23:52:05 | Re: Allowing extensions to find out the OIDs of their member objects |
Previous Message | Chapman Flack | 2019-01-21 23:48:53 | Re: PostgreSQL vs SQL/XML Standards |