From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, Stephen Froehlich <s(dot)froehlich(at)cablelabs(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |
Date: | 2018-03-06 07:21:24 |
Message-ID: | CAKJS1f8+e+CJGkavFpN5Bzpxiga0DyPY-m3EgERa5gCMvAYq1g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-novice |
On 6 March 2018 at 11:43, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Pushed now, to branches master and pg10, with Tomas changes. I made a
> few changes of my own
Great! Many thanks to both of you for making those changes and thanks
Alvaro for pushing.
> 3. I chose not to backpatch the node->stxcomment thing. It makes me
> nervous to modify a parse node. So cloning the comments is a PG11
> thing. Hopefully it's not *too* bad ...
Makes sense. We've had other objects previously that the comments were
lost sometimes, and I don't think they were noticed too quickly, so
perhaps this is an unlikely case that will bother too many people.
> 4. See elsewhere in the thread about list_copy vs. list_concat :-)
I saw that. Thanks for fixing. The only weird thing I see in the
changes is that the comment here claims it makes a copy, but it does
not.
+ * Right now, there's nothing to do here, so we just copy the list.
+ */
+static void
+transformExtendedStatistics(CreateStmtContext *cxt)
+{
+ cxt->alist = list_concat(cxt->alist, cxt->extstats);
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Edmund Horner | 2018-03-06 07:31:31 | Re: PATCH: psql tab completion for SELECT |
Previous Message | Amit Langote | 2018-03-06 06:28:21 | Re: inserts into partitioned table may cause crash |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2018-03-06 16:22:41 | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |
Previous Message | Alvaro Herrera | 2018-03-05 22:43:20 | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |