Re: pgsql: Fix tablespace handling for partitioned indexes

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix tablespace handling for partitioned indexes
Date: 2018-11-23 03:35:58
Message-ID: CAKJS1f-M3NMTCpv=vDfkoqHbMPFf=3-Z1ud=+1DHH00tC+zLaQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, 4 Nov 2018 at 05:33, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Fix tablespace handling for partitioned indexes

While working on something else, I noticed this:

# create table listp (a int) partition by list(a);
CREATE TABLE
# create index on listp (a) tablespace pg_global; -- properly disallowed
ERROR: only shared relations can be placed in pg_global tablespace
# create index on listp (a);
CREATE INDEX
# alter index listp_a_idx set tablespace pg_global; -- should be disallowed
ALTER INDEX
# create table listp1 partition of listp for values in(1);
ERROR: only shared relations can be placed in pg_global tablespace

A patch to fix is attached.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
disallow_partitioned_indexes_from_being_put_in_pg_global.patch application/octet-stream 642 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2018-11-23 07:54:42 pgsql: Add WL_EXIT_ON_PM_DEATH pseudo-event.
Previous Message Michael Paquier 2018-11-23 00:12:58 pgsql: Clarify documentation about PASSWORD in CREATE/ALTER ROLE