| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
| Subject: | Re: Passing CopyMultiInsertInfo structure to CopyMultiInsertInfoNextFreeSlot() |
| Date: | 2019-05-13 13:46:00 |
| Message-ID: | CAKJS1f-A5aYvPHe10Wy9LjC4RzLsBrya8b2gfuQHFabhwZT_NQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 13 May 2019 at 23:20, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
> In the latest PostgreSQL code, I could see that we are passing CopyMultiInsertInfo structure to CopyMultiInsertInfoNextFreeSlot() although it is not being used anywhere in that function. Could you please let me know if it has been done intentionally or it is just an overlook that needs to be corrected. AFAIU, CopyMultiInsertInfoNextFreeSlot() is just intended to return the next free slot available in the multi insert buffer and we already have that buffer stored in ResultRelInfo structure which is also being passed to that function so not sure what could be the purpose of passing CopyMultiInsertInfo structure as well. Please let me know if i am missing something here. Thank you.
There's likely no good reason for that. The attached removes it.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| remove_unused_parameter_from_CopyMultiInsertInfoNextFreeSlot.patch | application/octet-stream | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kuntal Ghosh | 2019-05-13 14:13:24 | Re: PANIC :Call AbortTransaction when transaction id is no normal |
| Previous Message | Tom Lane | 2019-05-13 13:37:32 | Re: PANIC :Call AbortTransaction when transaction id is no normal |