| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | David Zhang <david(dot)zhang(at)highgo(dot)ca> |
| Cc: | Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: psql: Add role's membership options to the \du+ command |
| Date: | 2023-02-15 21:37:52 |
| Message-ID: | CAKFQuwbmAFfDw9ScCiOxK4UGf8Z8ny1nDgAn41gOJCeJ76QC4Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 15, 2023 at 2:31 PM David Zhang <david(dot)zhang(at)highgo(dot)ca> wrote:
> There is a default built-in role `pg_monitor` and the behavior changed
> after the patch. If `\dg+` and `\du+` is treated as the same, and `make
> check` all pass, then I assume there is no test case to verify the output
> of `duS+`. My point is should we consider add a test case?
>
I mean, either you accept the change in how this meta-command presents its
information or you don't. I don't see how a test case is particularly
beneficial. Or, at least the pg_monitor role is not special in this
regard. Alice changed too and you don't seem to be including it in your
complaint.
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zheng Li | 2023-02-15 22:16:05 | Re: Support logical replication of DDLs |
| Previous Message | David Zhang | 2023-02-15 21:31:05 | Re: psql: Add role's membership options to the \du+ command |