| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Andres Freund <andres(at)anarazel(dot)de>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Antonin Houska <ah(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Full support for index LP_DEAD hint bits on standby |
| Date: | 2022-03-30 00:53:08 |
| Message-ID: | CAKFQuwbAGwG_hYA02N7wAsHro=3cxa0pytSMqZPPf+SpkjVh+g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 29, 2022 at 5:20 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Tue, Mar 29, 2022 at 4:55 AM Michail Nikolaev
> <michail(dot)nikolaev(at)gmail(dot)com> wrote:
>
> I think that you could do a better job of explaining and promoting the
> problem that you're trying to solve here. Emphasis on the problem, not
> so much the solution.
As a specific recommendation here - submit patches with a complete commit
message. Tweak it for each new version so that any prior discussion that
informed the general design of the patch is reflected in the commit message.
This doesn't solve the "experience" issue by itself but does allow someone
with interest to jump in without having to read an entire thread,
including false-starts and half-ideas, to understand what the patch is
doing, and why. At the end of the day the patch should largely speak for
itself, and depend minimally on the discussion thread, to be understood.
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2022-03-30 00:56:26 | Re: pg_stat_reset_single_*_counters vs pg_stat_database.stats_reset |
| Previous Message | Andres Freund | 2022-03-30 00:50:08 | Re: pg_stat_reset_single_*_counters vs pg_stat_database.stats_reset |