From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
---|---|
To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
Cc: | Joe Conway <mail(at)joeconway(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: documentation fix for SET ROLE |
Date: | 2021-03-08 23:41:29 |
Message-ID: | CAKFQuwb89v7u4UdCytOrMRs4JMH5kU7+XQjNdi+C8zApuCucKQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Feb 18, 2021 at 6:18 PM Bossart, Nathan <bossartn(at)amazon(dot)com> wrote:
> On 2/17/21 2:12 PM, David G. Johnston wrote:
> > On Wednesday, February 17, 2021, Bossart, Nathan <bossartn(at)amazon(dot)com
> > <mailto:bossartn(at)amazon(dot)com>> wrote:
> >
> >
> > postgres=# ALTER ROLE test1 SET ROLE test2;
> > ALTER ROLE
> >
> >
> > I would not have expected this to work - “role” isn’t a
> > configuration_parameter. Its actually cool that it does, but this doc
> fix
> > should address this oversight as well.
>
> Here's a patch that adds "role" and "session authorization" as
> configuration parameters, too.
>
>
You will want to add this to the commitfest if you haven't already.
I would suggest adding a section titled "Identification" and placing these
under that.
Reading it over it looks good. One point though: SET and SET ROLE are
indeed "at run-time" (not 'run time'). ALTER ROLE and ALTER DATABASE
should be considered "at connection-time" just like the command-line
options.
David J.
From | Date | Subject | |
---|---|---|---|
Next Message | David G. Johnston | 2021-03-08 23:48:34 | Re: documentation fix for SET ROLE |
Previous Message | David G. Johnston | 2021-03-08 23:22:31 | Re: cursor sensitivity misunderstanding |