From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
---|---|
To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-general(at)postgresql(dot)org" <pgsql-general(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Subject: | Re: [GENERAL] Request - repeat value of \pset title during \watch interations |
Date: | 2016-03-10 06:40:30 |
Message-ID: | CAKFQuwb1MA0EPDsUJ-rmEcnyWpxo2VzkXLLTNa2_3REvnofWkQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
Adding -hackers for consideration in the Commitfest.
Thanks!
David J.
>>>Original request by me
When executing a query using \watch in psql the first execution of the
query includes "Title is [...]" when \pset title is in use. Subsequent
executions do not. Once that first display goes off-screen the information
in the title is no longer readily accessible. If using \watch for a
long-running monitoring query it can be helpful to incorporate some context
information into the title.
---------- Forwarded message ----------
From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Date: Thu, Jan 28, 2016 at 6:01 AM
Subject: Re: [GENERAL] Request - repeat value of \pset title during \watch
interations
To: "David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-general(at)postgresql(dot)org" <
pgsql-general(at)postgresql(dot)org>
On Thu, Jan 28, 2016 at 1:54 PM, David G. Johnston
<david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> On Wed, Jan 27, 2016 at 9:13 PM, Michael Paquier <
michael(dot)paquier(at)gmail(dot)com>
> wrote:
>>
>> On Thu, Jan 28, 2016 at 9:34 AM, David G. Johnston
>> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>> > So how about:
>> >
>> > + snprintf(title, strlen(myopt.title) + 50,
>> > + _("Watch every %lds\t%s\t%s"),
>> > + sleep, head_title, asctime(localtime(&timer)));
>>
>> I would just keep the timestamp and the title separated so what do you
>> think about that instead?
>> Watch every Xs $timestamp
>> $head_title
>
>
> That works. I like having the title immediately above the table.
>
> The other option that came to mind would be to place the time information
> after the table display while leaving the title before it. On an output
> that requires more vertical space than is available in the terminal one
> would no longer have to scroll up to confirm last execution time. If
doing
> this I'd probably get rid of any logic that attempts to center the time
> information on the table and simply leave it left-aligned.
And the example:
OK, attached is an updated patch. How does that look?
Watch every 5s Fri Jan 29 13:06:31 2016
This is a medium length title
repeat
------------------------------------------------------------
------------------------------------------
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
(1 row)
Attachment | Content-Type | Size |
---|---|---|
psql_watch_title-v2.patch | text/x-diff | 1.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Condor | 2016-03-10 09:09:00 | Unable to match same value in field. |
Previous Message | David G. Johnston | 2016-03-10 03:07:45 | Re: Plan to support predicate push-down into subqueries with aggregates? |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2016-03-10 06:53:43 | Re: Add generate_series(date,date) and generate_series(date,date,integer) |
Previous Message | Amit Langote | 2016-03-10 06:36:20 | Re: [PROPOSAL] VACUUM Progress Checker. |