Re: Cascade view drop permission checks

On Wednesday, April 6, 2022, m7onov(at)gmail(dot)com <m7onov(at)gmail(dot)com> wrote:

> David, thank you for the clarification.
> Should we consider raising log level for cascade drops from NOTICE to
> WARNING? By now cascade drops appears in log files only when log level >=
> NOTICE.
>
> --- a/src/backend/catalog/dependency.c
> +++ b/src/backend/catalog/dependency.c
> @@ -1105,7 +1105,7 @@ reportDependentObjects(const ObjectAddresses
> *targetObjects,
> int flags,
> const ObjectAddress *origObject)
> {
> - int msglevel = (flags & PERFORM_DELETION_QUIETLY) ? DEBUG2 : NOTICE;
> + int msglevel = (flags & PERFORM_DELETION_QUIETLY) ? DEBUG2 : WARNING;
> bool ok = true;
> StringInfoData clientdetail;
> StringInfoData logdetail;
>

Please don’t top-post.

There is no point that I can see unless you also argue to warn/log about
every dropped object. Which can be done by the dba using event triggers if
they really want to.

They said cascade and got cascade. And can in-client set to notice and use
a transaction.

David J.