Re: Disabling vacuum truncate for autovacuum

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Gurjeet Singh <gurjeet(at)singh(dot)im>, Andres Freund <andres(at)anarazel(dot)de>, Will Storey <will(at)summercat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Disabling vacuum truncate for autovacuum
Date: 2025-03-21 15:54:55
Message-ID: CAKFQuwaduAUn=v-vnTkW0hXs2G5Yv0nxcHDDiuviet4FTxFzMQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Thu, Mar 20, 2025 at 11:13 AM Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:

>
> How does something like this look for the comment?
>
> /*
> * isset_offset is an optional offset of a field in the result
> struct
> * that stores whether the value is explicitly set for the
> relation or
> * has just picked up the default value. In most cases, this can
> be
> * deduced by giving the reloption a special default value (e.g.,
> -2 is
> * a common one for integer reloptions), but this isn't always
> * possible. One notable example is Boolean reloptions, where it's
> * difficult to discern the source of the value. This offset is
> only
> * used if given a value greater than zero.
> */
> int isset_offset;
>
>
>
I didn't actually come back to this before writing my comment.

I'm glad they both say basically the same thing.

I'm still partial to mine but yours probably fits the overall style of the
codebase better.

David J.

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Christoph Berg 2025-03-21 16:26:20 Re: query_id: jumble names of temp tables for better pg_stat_statement UX
Previous Message David G. Johnston 2025-03-21 15:50:31 Re: Disabling vacuum truncate for autovacuum

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrei Lepikhov 2025-03-21 15:56:09 Re: Memoize ANTI and SEMI JOIN inner
Previous Message Matheus Alcantara 2025-03-21 15:52:55 Re: RFC: Additional Directory for Extensions