| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | japin <japinli(at)hotmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "bharath(dot)rupireddyforpostgres(at)gmail(dot)com" <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Terminate the idle sessions |
| Date: | 2020-11-24 03:39:48 |
| Message-ID: | CAKFQuwaPbKYt-62RELgdNKvEbroTjhByt-ntn8GHfRtFO22H+w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 23, 2020 at 5:02 PM kuroda(dot)hayato(at)fujitsu(dot)com <
kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> No one have any comments, patch tester says OK, and I think this works
> well.
> I changed status to "Ready for Committer."
>
Some proof-reading:
v8-0001
Documentation:
My suggestion wasn't taken for the first note paragraph (review/author
disagreement) and the current has the following issues:
"if you use some connection-pooling" software doesn't need the word "some"
Don't substitute "pg" for the name of the product, PostgreSQL.
The word "used" is a more stylistic dislike, but "connected to using
postgres_fdw" would be a better choice IMO.
Code (minor, but if you are in there anyway):
(5) turn off ... timeout (there are now two, timeouts should be plural)
v8-0002 - No suggestions
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-11-24 03:51:43 | Re: Use macros for calculating LWLock offset |
| Previous Message | Etsuro Fujita | 2020-11-24 02:56:20 | Re: [POC] Fast COPY FROM command for the table with foreign partitions |