[HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Robins Tharakan <tharakan(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump
Date: 2018-01-23 02:07:13
Message-ID: CAKFQuwaJC6z+nYOBu8uSQX3oqPxDVUa7wtci42tWwtaNQRMSAw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Monday, January 22, 2018, Stephen Frost <sfrost(at)snowman(dot)net> wrote:

>
> In the end, I feel like this patch has actually been through the ringer
> and back because it was brought up in the context of solving a problem
> that we'd all like to fix in a better way. Had it been simply dropped
> on us as a "I'd like to not have comments in my pg_dump output and
> here's a patch to allow me to do that" I suspect it would have been
> committed without anywhere near this level of effort.
>

+0; but recognizing our users are going to remain annoyed by the existing
problem and that telling them that this is the answer will not sit well.

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-01-23 02:07:33 Re: [HACKERS] A design for amcheck heapam verification
Previous Message Michael Paquier 2018-01-23 01:59:46 Re: [HACKERS] Deadlock in XLogInsert at AIX