Re: "Alter system" command documentation

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Euler Taveira <euler(at)timbira(dot)com(dot)br>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, "pgsql-docs(at)postgresql(dot)org" <pgsql-docs(at)postgresql(dot)org>
Subject: Re: "Alter system" command documentation
Date: 2015-06-15 21:10:16
Message-ID: CAKFQuwZnoQKAi9qu_Vb6njo30x46MWZDNSExkvbs+hiOdjmHAA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Mon, Jun 15, 2015 at 4:58 PM, Euler Taveira <euler(at)timbira(dot)com(dot)br> wrote:

> On 15-06-2015 13:32, Jeff Janes wrote:
> > From http://www.postgresql.org/docs/current/static/sql-altersystem.html
> >
> > "Values set with ALTER SYSTEM will be effective after the next server
> > configuration reload (SIGHUP or pg_ctl reload), or after the next server
> > restart in the case of parameters that can only be changed at server
> start."
> >
> > Isn't it unfortunate that the command used for changing the
> > configuration file from within SQL mentions SIGHUP and pg_ctl reload,
> > but not "select pg_reload_conf();", as a way to activate that change?
> >
> SIGHUP is an implementation detail. If I were to change that sentence,
> my preference is replace SIGHUP with pg_reload_conf.
> ​
>

​I ​
disagree on SIGHUP being an implementation detail.

​ Using signals in IPC (inter-process communication) is a public API that
should be documented when applicable. Yes, various command-line and SQL
commands and functions have been provided so that one does not have to use
raw signals but they are still part of the public API for the application.

Adding mention of pg_reload_conf may be warranted (probably is but I
haven't made an independent evaluation) but removing SIGHUP is a separate
concern and one that doesn't seem necessary.

David J.

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Alvaro Herrera 2015-06-16 01:14:20 Re: "Alter system" command documentation
Previous Message Euler Taveira 2015-06-15 20:58:36 Re: "Alter system" command documentation