Have postgres.bki self-identify

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Have postgres.bki self-identify
Date: 2025-03-20 19:46:29
Message-ID: CAKFQuwZfakLYiB+=o1C7GG-N6YHKOuK_3ap6znaSsTULr6G4Lw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

While trying to find postgres.bki in my build directory searching for the
file name didn't work because there is no comment in the file containing
the file name; like there is in every other file we write or generate,
including the related *_d.h files. Add it.

It probably belongs before the version identifier but wasn't sure if that
placement would be considered something worth retaining.

diff --git a/src/backend/catalog/genbki.pl b/src/backend/catalog/genbki.pl
index 2501307c92..175fde4acc 100644
--- a/src/backend/catalog/genbki.pl
+++ b/src/backend/catalog/genbki.pl
@@ -458,6 +458,9 @@ open my $syscache_info_fh, '>', $syscache_info_file .
$tmpext
# version marker for .bki file
print $bki "# PostgreSQL $major_version\n";

+# self-identify file in comment per code policies.
+print $bki "# postgres.bki\n";
+
# vars to hold data needed for schemapg.h
my %schemapg_entries;
my @tables_needing_macros;

David J.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2025-03-20 19:52:45 Re: AIO v2.5
Previous Message Andres Freund 2025-03-20 18:54:14 Re: AIO v2.5