Re: maximum for auto_explain.log_min_duration doesn't seem to make sense

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kevin Bloch <kev(at)codingthat(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: maximum for auto_explain.log_min_duration doesn't seem to make sense
Date: 2018-02-23 19:27:29
Message-ID: CAKFQuwZfTAG1xVrvmxF7C0dnHtLbUVvJ2De3iObqw_HpGsE4fQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Feb 23, 2018 at 12:25 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> "David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> > On Fri, Feb 23, 2018 at 11:34 AM, Kevin Bloch <kev(at)codingthat(dot)com>
> wrote:
> >> According to https://dba.stackexchange.com/a/198429/28774 , this
> setting
> >> maxes out at INT_MAX / 1000, but since it's never multiplied by 1000 or
> any
> >> other number, it seems it should perhaps just be INT_MAX
>
> > ​I suspect that the counter to which that value is being compared also
> > wants to be an INT and if one checks for "val > INT_MAX" then val cannot
> be
> > restricted to an integer (and since we are capturing time we need some
> > unknown buffer).

>
>
In short, seems like a valid complaint to me.
>

​Yeah, I went back and pulled up the code and came to the same conclusion.

David J.

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Vinston Pandiyan 2018-02-23 19:34:21 Re: BUG #15083: [54000] ERROR: total size of jsonb array elements exceeds the maximum of 268435455 bytes
Previous Message Tom Lane 2018-02-23 19:25:59 Re: maximum for auto_explain.log_min_duration doesn't seem to make sense