Re: Document NULL

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Document NULL
Date: 2024-11-21 15:03:52
Message-ID: CAKFQuwZTLd__EMPj+G7hHP8T6aKnoH_batXMTRY6=udd8Xspaw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 20, 2024 at 7:24 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:

> On Wed, Nov 20, 2024 at 11:57 PM David G. Johnston
> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> >
> >> -------------------------------------------------------------
> >> in doc/src/sgml/nullvalues.sgml
> >> see the attached for one example output
> >>
> >> in doc/src/sgml/nullvalues.sgml we have
> >> one_whitespace<programlisting>
> >> two_whitespace<programlisting>
> >> three_whitespace<programlisting>
> >> four_whitespace<programlisting>
> >>
> >> i think you need zero whitespace for tag <programlisting>. like
> >> <programlisting>
> >> </programlisting>
> >>
> >> https://tdg.docbook.org/tdg/4.5/programlisting
> >> says whitespaces are significant.
> >
> >
> > Did you not apply patch 0002? The indentation in 0001 exists because it
> was much easier to deal with collapse-all related viewing in my editor. I
> removed it in 0002 since the final commit would indeed not be so indented.
> The tag itself doesn't actually care but its content does indeed get
> undesirably indented if the markup is nested in the typical manner.
> >
>
> i didn't apply patch 0002, 0001 is already too much.
>
> attached image.png for
> 5.2.7.2. Array Elements and IN Bag Members
> the example is too overwhelming, one or two should be enough?
>
> 5.2.7.3. Single-Column Subquery Rows.
> two examples, can be reduced to one.
>

Yeah, examples will be there own pass for cleanup as the patch gets closer
to acceptance.

> typo:
> There are none. During initializion all settings are assigned a non-null
> value.
> 5.2.16. Null Values in Partiton Keys
> As noted in the synatx chapter, a null value literal is written using
> the NULL keyword. Its type is the pseudo-type unknown but can be cast
> to any concrete data type.
>

Sorry, not seeing the typo. Can you point it out or supply the fix?

> ""
> At present this is typically a non-issue as PostgreSQL does not
> support a primary key that does not include partition key columns, and
> all columns in a primary key are forced to be have not null
> constraints.
> ""
> "does not support...does not include" double negation, can we make it
> "positive".
> "not null constraints." should be "not-null constraints"?
>

Yeah, I will clean that up.

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-11-21 15:09:35 Re: Accessing other session's temp table
Previous Message Marcos Pegoraro 2024-11-21 15:02:51 Re: Document NULL