Re: parallel.c is not marked as test covered

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Clément Prévost <prevostclement(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: parallel.c is not marked as test covered
Date: 2016-06-20 20:52:21
Message-ID: CAKFQuwZN-PXMTDRcHK+UPGZpZ8CKmvwy6EZzuArRHyM32Empfg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 20, 2016 at 4:03 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Mon, Jun 20, 2016 at 3:29 PM, David G. Johnston
> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> > The entire theory here looks whacked - and seems to fall into the "GUCs
> > controlling results" bucket of undesirable things.
>
> As far as I can see, this entire email is totally wrong and off-base,
> because the whole thing seems to be written on the presumption that
> single_copy is a GUC, when it's actually a structure member. If there
> was some confusion about that, you could have spent 5 seconds running
> "git grep" before writing this email, or you could have tried "SET
> single_copy" and discovered, hey, there's no such GUC.
>
> Furthermore, I think that describing something that you obviously
> haven't taken any time to understand as "whacked" is not very nice.
> For that matter, I think that describing something you *have* taken
> time to understand as "whacked" is not very nice.
>
>
​Point taken.

I don't think my entire post depends solely upon this being a GUC though.

​I've burned too many brain cells on this already, though, to dive much
deeper.

Internal or external I do think the number and type of flags described
here, for the purposes described, seems undesirable from an architectural
standpoint. I do not and cannot offer up more than that generally due to
knowledge and resource constraints. I tried to frame things up relative to
my understanding of existing, non-parallel, idioms, both to understand it
better myself and to throw out another POV from a fresh perspective. I'll
admit its one with some drawbacks but its offered in good faith.

Please do with it as you will and accept my apology for the poor choice
of colloquialism.

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2016-06-20 20:53:30 Re: 10.0
Previous Message Andres Freund 2016-06-20 20:51:23 Re: forcing a rebuild of the visibility map